search

veraison / corim

CoRIM and CoMID manipulation library and CLI
Apache License 2.0
9 stars 7 forks source link

Fixed MarshallJSON() #87

Closed Kakemone closed 1 year ago

Kakemone commented 1 year ago

Original MarshalJSON() method did not encode the raw-values as a tnv type which caused error upon unmarshaling. This commit adds this functionality and makes marshaling and unmarshaling symmetric

It also adds a round trip JSON Marshal and UnMarshal test for the raw values (a test that would have failed using the previous MarshalJSON method but passes with the corrected version)

yogeshbdeshpande commented 1 year ago

@Kakemone : I would request you create a test for a Round Trip JSON Marshal and UnMarshal, as part of the fix!

setrofim commented 1 year ago

Please also a dd a short commit message explaining the nature of the problem being fixed.