veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
50 stars 26 forks source link

Use cbor.SortCoreDeterministic for CBOR encoding #113

Closed qmuntal closed 1 year ago

qmuntal commented 1 year ago

Fixes #110

codecov[bot] commented 1 year ago

Codecov Report

Merging #113 (b2a1e5f) into main (77e3f9f) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          10       10           
  Lines         975      975           
=======================================
  Hits          895      895           
  Misses         54       54           
  Partials       26       26           
Impacted Files Coverage Δ
cbor.go 84.21% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

shizhMSFT commented 1 year ago

@qmuntal The notation-core-go project works well with the go-cose in this PR as confirmed by @patrickzheng200.

qmuntal commented 1 year ago

@thomas-fossati @yogeshbdeshpande PTAL

qmuntal commented 1 year ago

Can this be merged? Thanks!