Closed qmuntal closed 1 year ago
Merging #155 (fec382b) into main (cebef14) will decrease coverage by
0.25%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 91.48% 91.24% -0.25%
==========================================
Files 12 12
Lines 1633 1542 -91
==========================================
- Hits 1494 1407 -87
+ Misses 101 98 -3
+ Partials 38 37 -1
Impacted Files | Coverage Δ | |
---|---|---|
algorithm.go | 85.36% <ø> (-3.35%) |
:arrow_down: |
headers.go | 93.09% <100.00%> (-0.13%) |
:arrow_down: |
key.go | 88.86% <100.00%> (-0.85%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR removes a bunch of methods added in #146 which, in my opinion, shouldn't have been added.
This is the list and the reasoning for removing them:
Algorithm.UnmarshalCBOR
.Algorithm.UnmarshalCBOR
. Additionally, we should not error when the value is not supported by go-cose, as users might want to unmarshal a key using go-cose but create a signer/verifier using external code.KeyType.UnmarshalCBOR
.KeyType.UnmarshalCBOR
, also we shouldn't validate its value.Curve.UnmarshalCBOR
.Also, I've removed
KeyOpt.IsSupported
and its usage inKeyOpt.UnmarshalCBOR
. RFC 7517 Section 4.3 says that other values may be used.