veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
49 stars 26 forks source link

Centralize key validations and check more invalid cases #156

Closed qmuntal closed 1 year ago

qmuntal commented 1 year ago

This PR does the following:

codecov[bot] commented 1 year ago

Codecov Report

Merging #156 (c768d2b) into main (2f778da) will increase coverage by 0.47%. The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   91.05%   91.52%   +0.47%     
==========================================
  Files          12       12              
  Lines        1542     1545       +3     
==========================================
+ Hits         1404     1414      +10     
+ Misses        101       94       -7     
  Partials       37       37              
Impacted Files Coverage Δ
key.go 89.88% <84.61%> (+1.01%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

qmuntal commented 1 year ago

@thomas-fossati @yogeshbdeshpande @shizhMSFT please take a look.