Closed qmuntal closed 1 year ago
Merging #159 (fae3330) into main (bfe4717) will decrease coverage by
0.11%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 93.48% 93.38% -0.11%
==========================================
Files 11 11
Lines 1658 1678 +20
==========================================
+ Hits 1550 1567 +17
- Misses 75 78 +3
Partials 33 33
Impacted Files | Coverage Δ | |
---|---|---|
key.go | 95.90% <100.00%> (+0.13%) |
:arrow_up: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I looked at this, I agree its important to do, seems to be done correctly, but I am not a reliable CR for golang.
@yogeshbdeshpande, @shizhMSFT can you PTAL
This PR adds the following features:
x
,y
andd
parameters for OKP and EC2 keys have the right size.x
andy
for OKP and EC in case they are omitted, which is allowed by the COSE spec.