veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
49 stars 26 forks source link

Validate key sizes and allow signing with empty public keys #159

Closed qmuntal closed 1 year ago

qmuntal commented 1 year ago

This PR adds the following features:

codecov[bot] commented 1 year ago

Codecov Report

Merging #159 (fae3330) into main (bfe4717) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   93.48%   93.38%   -0.11%     
==========================================
  Files          11       11              
  Lines        1658     1678      +20     
==========================================
+ Hits         1550     1567      +17     
- Misses         75       78       +3     
  Partials       33       33              
Impacted Files Coverage Δ
key.go 95.90% <100.00%> (+0.13%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

OR13 commented 1 year ago

I looked at this, I agree its important to do, seems to be done correctly, but I am not a reliable CR for golang.

SteveLasker commented 1 year ago

@yogeshbdeshpande, @shizhMSFT can you PTAL