Closed qmuntal closed 1 year ago
Merging #161 (adad1c2) into main (a5dc571) will increase coverage by
0.20%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 93.59% 93.80% +0.20%
==========================================
Files 11 11
Lines 1687 1695 +8
==========================================
+ Hits 1579 1590 +11
+ Misses 75 72 -3
Partials 33 33
Impacted Files | Coverage Δ | |
---|---|---|
algorithm.go | 100.00% <100.00%> (+14.63%) |
:arrow_up: |
headers.go | 92.19% <100.00%> (-0.91%) |
:arrow_down: |
key.go | 95.94% <100.00%> (+0.03%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
PTAL @thomas-fossati @shizhMSFT
PTAL @thomas-fossati @shizhMSFT
@qmuntal : Thomas is on a long vacation. Please get the necessary comments from @shizhMSFT and then proceed with submission.
This PR contain the following changes:
NewXKey
toNewKeyX
, being X the key type. This form is more idiomatic.Key
prefix from Key properties. It is go-ish to avoid prefixing the name of a property with the name of the struct.XInvalid
toXReserved
, being XKeyType
,Curve
,KeyOp
andAlgorithm
. This makes our API more similar to the COSE spec naming.