search

veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
49 stars 26 forks source link

Upgrade fxamacker/cbor to v2.5.0 #166

Closed qmuntal closed 11 months ago

qmuntal commented 1 year ago

fxamacker/cbor release notes: https://github.com/fxamacker/cbor/releases/tag/v2.5.0.

Fixes #165

codecov[bot] commented 1 year ago

Codecov Report

Merging #166 (fbff149) into main (4451940) will increase coverage by 0.22%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   93.82%   94.05%   +0.22%     
==========================================
  Files          11       11              
  Lines        1701     1715      +14     
==========================================
+ Hits         1596     1613      +17     
+ Misses         72       69       -3     
  Partials       33       33
Files Coverage Δ
cbor.go 87.50% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SteveLasker commented 1 year ago

@qmuntal to evaluate what additional tests are required to build confidence to merge.

qmuntal commented 11 months ago

@qmuntal to evaluate what additional tests are required to build confidence to merge.

I've gone through the test suite of other COSE libraries, most notably https://github.com/google/coset, and I haven't found any outstanding missing case on our suite. IMO this is ready to merge.

SteveLasker commented 11 months ago

Thanks, @qmuntal