search

veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
51 stars 26 forks source link

Add conformance tests for Ed25519 signatures #171

Open henrylyons opened 1 year ago

henrylyons commented 1 year ago

What is the areas you would like to add the new feature to?

Go-COSE Library

Is your feature request related to a problem?

The project README states that this module supports Ed25519 signatures - however, there are no conformance tests for this. Please add conformance tests for these types of these signatures so that they can use to verify the correctness of the Ed25519 implementation in this module, and modules written in other languages as well (e.g., Rust).

What solution do you propose?

Add positive and negative conformance tests for Ed25519 signatures, covering signature creation and verification functionality.

What alternatives have you considered?

I can create separate Ed25519 conformance tests for my COSE implementation, but I prefer to have a common set of tests that can be used to test COSE implementations in different languages.

Any additional context?

No response

OR13 commented 1 year ago

https://datatracker.ietf.org/doc/html/rfc8152#section-8.2

Not sure if there are test vectors that we can import, but we should start by finding and linking them.

OR13 commented 1 year ago

Blocked pending: https://github.com/gluecose/test-vectors/issues/15

OR13 commented 1 year ago

Unblocked I think, see: https://github.com/gluecose/test-vectors/issues/15#issuecomment-1752432446