search

veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
49 stars 26 forks source link

Support for CWT Claims in Headers #173

Closed OR13 closed 1 month ago

OR13 commented 11 months ago

What is the areas you would like to add the new feature to?

Go-COSE Library

Is your feature request related to a problem?

See https://datatracker.ietf.org/doc/draft-ietf-cose-cwt-claims-in-headers/

What solution do you propose?

See https://datatracker.ietf.org/doc/draft-ietf-cose-cwt-claims-in-headers/

What alternatives have you considered?

None.

Any additional context?

Once this document becomes an RFC it is advisable to add support for it to protected headers.

SteveLasker commented 10 months ago

Blocked (labeled) pending the RFC

OR13 commented 9 months ago

its still progressing, the code points have changed.

its also debatable if this should be done in this repo, will there be a go-cwt ?

OR13 commented 9 months ago

@thomas-fossati @qmuntal do you think we should do all the CWT stuff in a seperate repo? if so, this issue should probably be closed.

thomas-fossati commented 8 months ago

@thomas-fossati @qmuntal do you think we should do all the CWT stuff in a seperate repo?

hi @OR13! I've just glanced through the draft and, unless I'm mistaken, there is no special processing that needs to happen at the COSE layer. So, apart from adding the registered "CWT Claims" code-point into the consts list in headers.go, I don't see any other actions for go-cose.

if so, this issue should probably be closed.

We can keep this open until the IANA registration has completed, at which point we add the const and close it.

SteveLasker commented 7 months ago

@OR13 agreed to initiate a PR for review.

OR13 commented 7 months ago

PR is up here: https://github.com/veraison/go-cose/pull/183