veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
49 stars 26 forks source link

Cut v1.3.0-alpha.1 Release #190

Closed SteveLasker closed 1 month ago

SteveLasker commented 1 month ago

@veraison/go-cose-maintainers, please +1 to create a v1.2.0-alpha.1 release, or create/reference issues or new PRs that should be considered prior.

SteveLasker commented 1 month ago

@shizhMSFT, @setrofim, @qmuntal, @thomas-fossati, @yogeshbdeshpande, @roywill Please provide your vote for a release.

shizhMSFT commented 1 month ago

@SteveLasker Could you specify the commit proposed to be tagged as v1.2.0-alpha.1?

SteveLasker commented 1 month ago

Great question. We should make a template for releases

Let’s start with: https://github.com/veraison/go-cose/commit/8c458e278da806b56444d1cbfd6ec24fc28aad9c

yogeshbdeshpande commented 1 month ago

+1 for release

setrofim commented 1 month ago

+1

SteveLasker commented 1 month ago

Released: https://github.com/veraison/go-cose/releases/tag/v1.2.0-alpha.1 Need to resolve the version #

SteveLasker commented 1 month ago

see #192

shizhMSFT commented 1 month ago

@SteveLasker @yogeshbdeshpande @setrofim It seems that v1.2.0-alpha.1 is released. Note that as a golang library, it is released as long as there is a new tag no matter whether a release page is created or not.

I also noticed that we previously published v1.2.0 in error and retracted it in v1.2.1. Technically, our next version should be v1.3.0-alpha.1 not v1.2.0-alpha.1.

shizhMSFT commented 1 month ago

Linking

SteveLasker commented 1 month ago

I saw the retraction after digging in. Does anyone have a concern jumping to v1.3.0-alpha.1 ?

OR13 commented 1 month ago

We should make sure the latest release matches to the latest tag.

SteveLasker commented 1 month ago

Updated the title to reflect the updated version

SteveLasker commented 1 month ago

https://github.com/veraison/go-cose/releases/tag/v1.3.0-alpha.1