Closed SteveLasker closed 2 months ago
@yogeshbdeshpande, @setrofim, @qmuntal, @thomas-fossati, @shizhMSFT, @roywill Can you please provide your perspective to ⬆️
DCO is important to open-source projects and more details can be found in https://github.com/apps/dco
I know people are struggling with web-based commits such as no sign-off when accepting suggestions. For example,
However, this can be easily mitigated by toggling Require contributors to sign off on web-based commits
in the repository setting. Detailed doc can be found at https://docs.github.com/en/organizations/managing-organization-settings/managing-the-commit-signoff-policy-for-your-organization
After applying the above setting, the web UI on GitHub will become
It shows Sign off and commit suggestion
.
As you can see, the commit is properly signed off.
Thanks, @shizhMSFT, We don't object to signing, rather the alignment of the tools. I've enabled "Require contributors to sign off on web-based commits " and will do some testing shortly. If that solves the usability problem for contributors and authors to use the github tools, I don't mind keeping the DCO capability.
Closing, until it bites us again...
Implementing DCO is great, in concept. Unfortunately the productive github tools to accept suggestions fights with DCO making the process broken for accepting suggestions.
Maintainers have the responsibility to accept or decline suggestions and/or PRs from individuals.
We will still follow the process for knowing who made what commits, and they should sign their commits.
Please 👍 if you agree, or comment if you disagree