search

veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
50 stars 26 forks source link

negative tests #22

Closed thomas-fossati closed 2 years ago

thomas-fossati commented 2 years ago

We need to add some negative tests. Ideally the test spec for these should come through GlueCOSE, same as we do with the positive test cases. So I have started by drafting a small document that isolates requirement language from the COSE RFC and identifies test conditions (see the Negative conditions sub-sections) that are relevant in the context of Sign1.

@shizhMSFT, @SteveLasker, @qmuntal: Please see here for a human-friendly read-out, and this one to add your comments / discuss further.

Based on your feedback I'll start writing the GlueCOSE test vectors we need.

qmuntal commented 2 years ago

I've added negative tests in #26. The test-vectors tests were really useful!

qmuntal commented 2 years ago

Can this be closed? We already integrated some negative conformance tests and implemented multiple negative unit tests.

Conformance suite still need to grow, but I would say the goal of this issue is meet.