search

veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
50 stars 26 forks source link

Use curve modulo instead of field size to calculate ECDSA signature length #60

Closed qmuntal closed 2 years ago

qmuntal commented 2 years ago

Fixes #59

@SteveLasker @shizhMSFT

SteveLasker commented 2 years ago

@sylvanc, @roywill can you also please provide some 👀's

SteveLasker commented 2 years ago

Thanks @qmuntal, @jaredpar, @yogeshbdeshpande @pornin, do you mind taking a look to confirm it meets your goals for #59?

pornin commented 2 years ago

The change to ecdsa.go is exactly what I had in mind.

SteveLasker commented 2 years ago

Thanks @pornin, awesome work @qmuntal