veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
50 stars 26 forks source link

Create v1.0.0-rc.1 release #88

Closed SteveLasker closed 2 years ago

SteveLasker commented 2 years ago

Complete the v1.0.0-rc.1 release in prep for a 1.0.0 release

High-level deliverables as follows:

Can the maintainers please respond with a +1 comment once you are in favor of cutting this release?

thomas-fossati commented 2 years ago

Not sure I understand why is the branch needed?

SteveLasker commented 2 years ago

Thanks @thomas-fossati The branch maintains the state for any fixes required to patch a release. See https://github.com/veraison/go-cose/tree/v1.0.0-alpha.1 as an example

thomas-fossati commented 2 years ago

Sure, but we can always cut it opportunistically -- should a bug be uncovered. Anyway, I'm certainly not against! Thanks for the explanation.

SteveLasker commented 2 years ago

Looks like all the remaining v1.0.0-rc.1 release items are complete.

Suggesting 33ff2e9 as the commit

qmuntal commented 2 years ago

main is currently under 89% coverage. I've filled #89 to fix it. I would wait until it is merged to cut a new release.

SteveLasker commented 2 years ago

Updated proposed git to: https://github.com/veraison/go-cose/commit/ebba05d25c1dc9a5eed3acf25446b7931291e1f4

Please :+1: if you agree to this commit as the base for rc.1

SteveLasker commented 2 years ago

👍

SteveLasker commented 2 years ago

@yogeshbdeshpande, @roywill, can you provide an 👍

yogeshbdeshpande commented 2 years ago

Hi @SteveLasker . I have provided my 👍 for the release.

Thanks for all the work.

SteveLasker commented 2 years ago

rc.1 is now released: https://github.com/veraison/go-cose/releases/tag/v1.0.0-rc.1 I'll make a few PRs to update the readme, and assure the security review is more prominent before closing this issue.

Kudos to all contributors in achieving this major step to a 1.0.0, enabling the community to adopt cose for security efforts.

thomas-fossati commented 2 years ago

rc.1 is now released: https://github.com/veraison/go-cose/releases/tag/v1.0.0-rc.1 I'll make a few PRs to update the readme, and assure the security review is more prominent before closing this issue.

Kudos to all contributors in achieving this major step to a 1.0.0, enabling the community to adopt cose for security efforts.

Awesome, huge thanks to all. And especially huge ones for @qmuntal and @shizhMSFT :-)

yogeshbdeshpande commented 2 years ago

Indeed thank you everyone and special thanks to @qmuntal and @shizhMSFT for raising the bar further on the go-cose security aspects.

Look forward to more such important milestones we publish together!