veraison / go-cose

go library for CBOR Object Signing and Encryption (COSE)
Mozilla Public License 2.0
50 stars 26 forks source link

Create 1.0.0 Release #98

Closed SteveLasker closed 1 year ago

SteveLasker commented 2 years ago

Complete the 1.0.0 release

High-level deliverables as follows:

Before we ask for a +1 to cut the release, we're asking for a few of the dependent projects to confirm rc.1 is ready for a 1.0.0 release

~Can the maintainers please respond with a +1 comment once you are in favor of cutting this release?~

SteveLasker commented 1 year ago

Noting: https://github.com/notaryproject/notation-core-go/issues/37#issuecomment-1380690416 as confidence in the 1.0 release. There are some new feature requests, but these could come post 1.0. Providing a solid 1.0, with 2 public security reviews completed, speaks to our readiness.

thomas-fossati commented 1 year ago

We have been using the v1.0.0 release candidate in four different places for a while now, and there has been no problem except for https://github.com/veraison/go-cose/issues/115 which is now fixed in the main branch. We are confident that main (c5ba0da) is ready to ship.

roywill commented 1 year ago

We should release.

SteveLasker commented 1 year ago

@veraison/go-cose-maintainers, can you please give a +1 to cutting the 1.0 release based on https://github.com/veraison/go-cose/commit/c5ba0da4875655e378aebd16654ad367c9c6edc4?

SteveLasker commented 1 year ago

+1 to release, based on https://github.com/veraison/go-cose/commit/c5ba0da4875655e378aebd16654ad367c9c6edc4

yogeshbdeshpande commented 1 year ago

+1

roywill commented 1 year ago

+1


From: Yogesh Deshpande @.> Sent: Wednesday, January 18, 2023 9:15 AM To: veraison/go-cose @.> Cc: Roy Williams (COSINE) @.>; Assign @.> Subject: Re: [veraison/go-cose] Create 1.0.0 Release (Issue #98)

+1

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fveraison%2Fgo-cose%2Fissues%2F98%23issuecomment-1387434976&data=05%7C01%7Croywill%40exchange.microsoft.com%7C02e147392ede4cfcb1c608daf9778a08%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638096589065787117%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pp7MfX2ri328tRVe%2FiOhCkZUU38Gou33jt%2FLVY8%2FOU8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJP7OQBMJC7QKTXCW3VR2SDWTAQJPANCNFSM56MAN4BA&data=05%7C01%7Croywill%40exchange.microsoft.com%7C02e147392ede4cfcb1c608daf9778a08%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638096589065787117%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lDqrvN2aeZweu%2FHtPxnNLQBVP9Du5vTZVSX%2Bf9zGGeg%3D&reserved=0. You are receiving this because you were assigned.Message ID: @.***>

SteveLasker commented 1 year ago

🎉 v1.0.0

SteveLasker commented 1 year ago

Remaining PR to update the readme: https://github.com/veraison/go-cose/pull/121

SteveLasker commented 1 year ago

Closing as 1.0 is released, and the readme is updated.