search

veraison / services

Attestation verification services based on Veraison components
Apache License 2.0
24 stars 13 forks source link

kvstore: add GetMultiple #220

Closed setrofim closed 2 weeks ago

setrofim commented 4 months ago

Add GetMultiple method to IKVStore that allows fetching values for multiple keys from a store with a single call. This simplifies the usage of the store inside trusted services and can potentially improve performance for remote store implementations where call overhead may be non-trivial.

This addresses https://github.com/veraison/services/issues/207

yogeshbdeshpande commented 4 months ago

Also, is the same not true for Add() Interface, used with one example on main branch: trustedservices_grpc.go line 318-322

thomas-fossati commented 2 weeks ago

Just checking since I have lost the context: is this change still required?

setrofim commented 2 weeks ago

Just checking since I have lost the context: is this change still required?

It was more of a nice-to-have refactor. Given that we have larger issues looming around KVStore, I don't think this is worth the churn.