search

veraison / services

Attestation verification services based on Veraison components
Apache License 2.0
25 stars 14 forks source link

update README for clarity #243

Closed gagichce closed 1 month ago

thomas-fossati commented 2 months ago

Hi @gagichce, thanks for the PR, and apologies for the belated reply! (This likely fell through the summer holidays cracks.)

Two notes:

  1. Which platform and shell are you using to run the commands? I am asking because on Linux & MacOSX (with both bash and zsh) the instructions work as-is (i.e., without the added ./).
  2. Could you please fix the DCO?
gagichce commented 2 months ago

It was Ubuntu based - I've since wiped the machine I was running this on.

You can close this PR if it works as is for most. Not sure why I had issues 🤷‍♂️

thomas-fossati commented 1 month ago

Thanks for the update @gagichce. I am closing the PR then.

Sorry, I hope you will be able to contribute soon!