veraison / services

Attestation verification services based on Veraison components
Apache License 2.0
26 stars 14 forks source link

BUG: Old `cocli` repository used in native deployment #276

Closed zos closed 3 weeks ago

zos commented 3 weeks ago

What version of the package are you using?

v0.0.2411

Does this issue reproduce with the latest release?

Yes

What OS and CPU architecture are you using (go env)?

Does not matter for this issue

What did you do?

Check dependencies for native deployment: https://github.com/veraison/services/blob/0adce383bfe578423d4fb603658f864107137f8f/deployments/native/deployment.sh#L213-L216

What did you expect to see?

Based on docker deployment: https://github.com/veraison/services/blob/0adce383bfe578423d4fb603658f864107137f8f/deployments/docker/src/builder.docker#L63

I would expect to see a dependency with an updated repository link and commit sha

    function init_clients() {
    _init_client evcli github.com/veraison/evcli/v2@86d12893
    _init_client cocli github.com/veraison/cocli@4eada925
    _init_client pocli github.com/veraison/pocli@2fa24ea3
}

What did you see instead?

Old repository link to cocli and commit sha: https://github.com/veraison/services/blob/0adce383bfe578423d4fb603658f864107137f8f/deployments/native/deployment.sh#L215

zos commented 3 weeks ago

Not sure if it makes sense to create another issue for one line in documentation, but old repository path is also mentioned here: https://github.com/veraison/services/blob/0adce383bfe578423d4fb603658f864107137f8f/end-to-end/walkthrough.md?plain=1#L232-L234

zos commented 3 weeks ago

I will create a PR for this tomorrow. Just let me know if I can include a fix for the mentioned documentation issue.