search

verakohh / pe

0 stars 0 forks source link

Exception handling error with addlesson command #2

Open verakohh opened 3 days ago

verakohh commented 3 days ago

Steps to reproduce:

  1. Enter addlesson 1 l/Monday 0900-110 or addlesson 2 l/Sunday 0900-110 in the command box

Expected behaviour:

Error thrown for invalid time formatting

Actual behaviour:

Nothing happens on GUI, but the terminal reports an exception(see screenshots)

Screenshot

image.png

image.png

image.png

Potential problematic behaviour:

User does not know if the app crashed or if the lesson is added successfully

nus-se-script commented 6 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is a valid bug, as we have managed to reproduce it. Thanks for catching this. The severity however, we feel that it is a Low, as this only happens in this very specific case where the user types in a 3 digit HHMM time. This does not happen for a 2 digit HHMM or 1 digit HHMM time. Additionally this doesn't allow the users to add the invalid lesson time either. Hence, we feel that this causes a minor inconvenience to the user as the remedy would be simply to fill in 1 more digit for the time in HHMM as stated in our User Guide with clear examples.

image.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]