search

verakohh / pe

0 stars 0 forks source link

Confusing Example for find command #5

Open verakohh opened 3 days ago

verakohh commented 3 days ago

From page 15 of UG under find command example(see screenshot), the command find ld/monday lt/1000-1100 may be misleading as users might think that this command will display the contacts whom I have a monday class from 1000-1100 with, an 'AND' feature rather than a 'OR' feature.

Furthermore, the 'Next Lesson" field in the contacts would further confuse the users as the users might not see the lessons mentioned in the relevant search. For example, contact at index 4, Jon Doe, that shows the next lesson as Friday 2000-2100, which is not part of both 'monday' and '1000-1100'

Steps to reproduce:

  1. Enter find ld/monday lt/1000-1100 command

Expected output:

Display the contacts whom I have a monday class from 1000-1100 with.

Actual Output: (Explained above)

Screenshots:

image.png

image.png

nus-pe-script commented 4 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

In our UG, we have stated this about our find command: Persons with at least one parameter matching at least one of its keyword will be returned (i.e. OR search). (see image below for screenshot)

image.png

We have also given examples where this is the case:

image.png

Hence, I don't think it is misleading as it is documented clearly that it is an OR search for at least one parameter matching at least one of its keywords.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]