search

verbal-autopsy-software / InSilicoVA

R package for InSilicoVA framework
3 stars 6 forks source link

Remove unnused arrays in TruncBeta* functions #30

Open jarathomas opened 10 months ago

jarathomas commented 10 months ago

The family of TruncBeta* methods in the InsilicoSampler create arrays, but do not use them:

        // create a new transpose probbase matrix
        double[][] new_probbase = new double[this.C][this.S];
        for(int s=0; s<this.S; s++){
            for(int c=0; c < this.C; c++){new_probbase[c][s] = this.probbase[s][c];}
        }

These should be removed. Here are the instances in the code:

https://github.com/verbal-autopsy-software/InSilicoVA/blob/9a2eb1750a050ac29ce35ad9825b8cc3ad5a022c/InSilicoVA/java/Insilico/src/sampler/InsilicoSampler2.java#L364

https://github.com/verbal-autopsy-software/InSilicoVA/blob/9a2eb1750a050ac29ce35ad9825b8cc3ad5a022c/InSilicoVA/java/Insilico/src/sampler/InsilicoSampler2.java#L452

https://github.com/verbal-autopsy-software/InSilicoVA/blob/9a2eb1750a050ac29ce35ad9825b8cc3ad5a022c/InSilicoVA/java/Insilico/src/sampler/InsilicoSampler2.java#L541