verbal-autopsy-software / InSilicoVA

R package for InSilicoVA framework
3 stars 6 forks source link

Enhancement: Suggestion to check for WHO2016 #8

Closed mjutras-mitre closed 4 years ago

mjutras-mitre commented 5 years ago

Although the code works as is.. And at line 883 we try to prevent problems by stopping if not WHO2012 or WHO2016, code can change over time.

For maintenance reasons, it would be safer to explicitly check for "WHO2016" in the else clause noted here. The else clause is in all likelihood specific to WHO2016 anyway.

https://github.com/verbal-autopsy-software/InSilicoVA/blob/7f5169a4477cc5f6fca7a68bf9c12758bd94d915/InSilicoVA/R/insilico_core.r#L1016-L1020