verbal-autopsy-software / InterVA4

R package for InterVA-4 software
0 stars 4 forks source link

Enhancement: In-Loop Replacement #3

Open mboyas-mitre opened 5 years ago

mboyas-mitre commented 5 years ago

https://github.com/verbal-autopsy-software/InterVA4/blob/792fd94fcad1f143f55865e580a4ea0bc233e5bb/InterVA4_1.7/R/InterVA.R#L288-291

These lines are converting categorical to binary on a line-by-line basis. It might be easier (and likely more efficient) to move this operation outside of the for loop and convert the entire input dataset at once.

richardli commented 5 years ago

agree, only doing this because of replication from the InterVA software.