verbb / cp-nav

Control Panel Nav is a Craft CMS plugin to help manage your Control Panel navigation.
MIT License
129 stars 11 forks source link

Categories Icon in Navigation #121

Open RitterKnightCreative opened 1 year ago

RitterKnightCreative commented 1 year ago

Describe the bug

What happened?

Description

Upstream must have did some refactoring to the CMS icons.

This was 3.7.x: Screenshot 2023-03-19 at 11 27 19 PM

This is 3.8: Screenshot 2023-03-20 at 12 13 34 AM

Since updating to Craft CMS 3.8, the Categories icon seems to be doubling up...

Screenshot 2023-03-19 at 11 28 00 PM

In the icon picker for CP Nav, it shows this:

Screenshot 2023-03-19 at 11 56 58 PM

Doesn't seem to affect any functionality. I worked around it by choosing a different icon from the list.

Craft CMS version

3.8.3

Steps to reproduce

  1. Upgrade to Craft 3.8

Craft CMS version

3.8

Plugin version

3.0.17

Multi-site?

No response

Additional context

No response

engram-design commented 1 year ago

Looks like they've removed category, categories as an icon, and it's replaced with tree. I'll see what I can do to migrate that automatically. Refer to https://github.com/craftcms/cms/commit/3ea8bbc8c24c8838e7f7babed6a6506b4ecb7058#diff-b83268224a9371ae59930e1deb83f59e1a241cdbdc2b5ac3013ee4c74f0f5a59

engram-design commented 1 year ago

FYI, tree is the new categories icon in Craft 3.8+, and available in 3.1.0

terryupton commented 1 year ago

Hey @engram-design I am still seeing this issue across several sites I am afraid. All sites are on [3.1.0](https://github.com/verbb/cp-nav/releases/tag/3.1.0)

Screenshot 2023-06-04 at 11 17 27
engram-design commented 1 year ago

And your Craft version? You may also need to switch over to tree manually

image
terryupton commented 1 year ago

Yeah that was it. Thanks @engram-design