verbb / cp-nav

Control Panel Nav is a Craft CMS plugin to help manage your Control Panel navigation.
MIT License
129 stars 11 forks source link

Custom Icons Not Working #34

Closed mikegraham00 closed 6 years ago

mikegraham00 commented 6 years ago

Description

Craft 3. I have selected custom icons for my CP Nav items, but only seeing the placeholder letters. This works correctly in the C2 version with the same icon files.

Steps to reproduce

  1. Create a CP Nav item 2.Add a custom SVG icon

Additional info

engram-design commented 6 years ago

@mikegraham00 I've tried a few SVG icons on my end, and all working well. Are you able to send through what you're testing? Not sure if it makes a difference, but I've noticed on some other Craft 3 installs that SVG's haven't worked that well if they're missing the XML definition <?xml version="1.0" encoding="utf-8"?> above it.

Are you trying to add the icon to a custom nav item, plugin or built-in nav item?

mikegraham00 commented 6 years ago

Thanks for the response. I tried adding the XML declaration to an icon before uploading but didn't seem to help.

Here is an example icon I'm trying to use. `

`

Thanks again.

engram-design commented 6 years ago

Well, thats even more bizarre, as that exact icon is working for me. See attached.

What browser/OS are you using? Any other plugins installed that could mess with things?

screen shot 2018-02-21 at 9 01 34 am

mikegraham00 commented 6 years ago

Yeah really weird. Must be something funky in my setup though SVGs in that volume are working fine on the front end...I'm on Chome/Mac.

engram-design commented 6 years ago

I'll see what I can do to reproduce the issue, also on Chrome/Mac.

Can you confirm if you're trying to add the icon to a custom nav item, plugin or built-in nav item?

mikegraham00 commented 6 years ago

Thanks. Trying to add it to a custom nav item.

mikegraham00 commented 6 years ago

I may try it on a fresh install to see if I can isolate the issue. Can you show me your working asset volume setup?

One thing I didn't mention is that I am using multisite on this install. Don't think that is the cause, but just wanted to be clear.

mikegraham00 commented 6 years ago

I found the issue. I was using @webroot in my file system path for this volume. I removed that and it immediately worked. Thanks for looking into it. Sorry for the time waster. Love the plugin.