verbb / events

Craft CMS Plugin for events management and ticketing.
Other
22 stars 13 forks source link

Event fieldLayout tabs won't open from dropdown menu click #112

Closed anchovy closed 2 years ago

anchovy commented 2 years ago

Describe the bug

We've got multiple tabs per event. Clicking to go to a tab in the dropdown menu throws a JS error Invalid tab ID in Tabs.js:191

image

NB - issue is the same for visible and non-visible tabs.

Steps to reproduce

  1. Goto an event & reduce your browser width/open browser developer tools
  2. Ensure there's at least one tab hidden
  3. Click on the drop-down menu in the tab ribbon
  4. Click on a tab item
  5. Check the 'Console' view for the error
image

Craft CMS version

Craft Pro 3.7.54

Plugin version

1.4.22

Multi-site?

No

Additional context

Navigating tabs in entries works as expected.

engram-design commented 2 years ago

Fixed for the next release. To get the fix early, change your verbb/events requirement in composer.json to:

"require": {
  "verbb/events": "dev-craft-3 as 1.4.22",
  "...": "..."
}

Then run composer update.

engram-design commented 2 years ago

Fixed in 1.4.23