search

verbb / events

Craft CMS Plugin for events management and ticketing.
Other
22 stars 13 forks source link

Conflict with seomatic 5.1.6 #157

Closed cloudgrayau closed 1 week ago

cloudgrayau commented 1 week ago

Describe the bug

PHP Compile Error – yii\base\ErrorException Declaration of verbb\events\integrations\seomatic\Event::previewUri(string $sourceHandle, $siteId) must be compatible with nystudio107\seomatic\base\SeoElementInterface::previewUri(string $sourceHandle, $siteId, $typeId = null): ?string

Steps to reproduce

After upgrade to the latest versions of seomatic and events.

Craft CMS version

5.5.0

Plugin version

3.0.1

Multi-site?

Yes

Additional context

No response

cloudgrayau commented 1 week ago

It appears the last update of seomatic has changed that function. I have reverted seomatic back to 5.1.5 for now.

@khalwat

engram-design commented 1 week ago

Yep, their plugin changed the method signatures (a breaking change, I’ve already told Andrew off haha), but will get a patch to address it on my end.

engram-design commented 1 week ago

Fixed in 3.0.2

khalwat commented 1 week ago

Sorry guys, this is my bad. I didn't realize anyone outside of custom module users were using this interface.