verbb / events

Craft CMS Plugin for events management and ticketing.
Other
22 stars 13 forks source link

Breaks the "Add a line item" option in the CP order/cart edit #63

Closed joshangell closed 4 years ago

joshangell commented 4 years ago

Description When you edit a cart or order in the CP having Events installed breaks the "Add a line item" option when editing an order or cart.

Steps to reproduce

  1. Create an order in the CP or make one on the front-end.
  2. Click "Add a line item" and search for anything.
  3. In the browser console the XHR request to /admin/actions/commerce/orders/purchasables-table?sort=&page=1&per_page=10&search=book returns a 500 error with the response:
{
    "error":"Getting unknown property: verbb\\events\\elements\\Ticket::priceAsCurrency"
}

Additional info

engram-design commented 4 years ago

Yeah, looks like a Commerce 3.5.x change, but I can't actually see where priceAsCurrency is documented. Looking into it, as it effects a few other custom purchasables.

joshangell commented 4 years ago

Ace, I figured it was.

engram-design commented 4 years ago

@joshangell Refer to Commerce's issue - https://github.com/craftcms/commerce/issues/1646

engram-design commented 4 years ago

Fixed in Commerce 3.2.2