verbb / events

Craft CMS Plugin for events management and ticketing.
Other
22 stars 13 forks source link

jsvrcek/ics dependency updated for php 8.0 support #99

Closed stuh closed 2 years ago

stuh commented 2 years ago

When installing the plugin to a PHP8 site I'm seeing the following.

Composer output: Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

Problem 1
- verbb/events 1.4.20 requires jsvrcek/ics ^0.7.0 -> satisfiable by jsvrcek/ics[0.7].
- jsvrcek/ics 0.7 requires php ^5.4 || ^7.0 -> your php version (8.0; overridden via config.platform, actual: 8.0.16) does not satisfy that requirement.
- Root composer.json requires verbb/events 1.4.20 -> satisfiable by verbb/events[1.4.20].

Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.

Steps to reproduce

  1. Go to Admin > Plugin Store > Events
  2. Click Try

Additional info

The jsvrek/ics dependency has a new release which bumps the supported php version in the composer file. More details here https://github.com/jasvrcek/ICS/issues/59

I also see it fixed in the Craft 4 branch.

Thanks

engram-design commented 2 years ago

Already updated this for Craft 4 / Events 2, and fortunately looks like jsvrcek/ics:^0.8.0 supports PHP 7+ as well, so this won't be a breaking change. Thanks!

itsmattsoria commented 2 years ago

Does this mean we can only use this for a site on PHP 8 with Craft 4?

engram-design commented 2 years ago

@itsmattsoria Nope, you can use this for Craft 3 and PHP 7, this dependancy just adds support for PHP 8 for both Craft 3 or Craft 4.