search

verbb / field-manager

Field Manager is a Craft CMS plugin to make it easy to manage your fields and field groups.
MIT License
199 stars 16 forks source link

Fix checkbox layout #4

Closed timkelty closed 9 years ago

timkelty commented 9 years ago

Checkbox layout was wonky (labels on new line). Here's a fix!

engram-design commented 9 years ago

Happy to merge this - although interested in what you're seeing as wonky. Using Chrome the checkboxes are nice and tidy - I even had to put a few special rules in there to fix this because it annoyed me.

In fact, applying this makes fields wonky. See attached before/after comparison.

Would you be able to provide a screenshot?

screen shot 2015-04-28 at 11 57 50 pm

timkelty commented 9 years ago

Sure: screen shot 2015-04-28 at 10 02 15 am screen shot 2015-04-28 at 10 02 09 am

engram-design commented 9 years ago

@timkelty Haha - okay so thats pretty bad :)

timkelty commented 9 years ago

Might have been a craft version difference?

timkelty commented 9 years ago

Yeah if you want to re-tweak the vertical alignment of those, I'll leave that to you.

engram-design commented 9 years ago

Maybe! I've been running it on the last few versions (lets say roughly past 5-6 version) and worked okay. Didn't realise it was so bad, so thanks for bringing it to my attention. +1 for the pull request too :)

timkelty commented 9 years ago

Yep that was it. I was on an older (2.2) install. Your previous version looks fine on 2.3. IMO, however, you should have stuff in those labels, so I still think my PR is valid.

Might just need some pixel pushing.

engram-design commented 9 years ago

Yep, good call, and agree.