search

verbb / formie

The most user-friendly forms plugin for Craft CMS.
Other
93 stars 69 forks source link

Default error message "Couldn’t save submission due to errors." not translated despited existing translation. #1771

Closed melissadoyon closed 3 months ago

melissadoyon commented 3 months ago

Describe the bug

Since updating form 2.1.3 to 2.1.7, I have noticed that the error message displayed at the top of my forms in not being translated despite the existing translation formie.php file.

Steps to reproduce

  1. Create a form
  2. Create a translation file named formie.php inside translations folder (ex. translations/fr/formie.php).
  3. Submit form without filling it on a language other than english.

Form settings

Craft CMS version

4.8.3

Plugin version

2.1.7

Multi-site?

No

Additional context

Other translations seems to work just fine.

engram-design commented 3 months ago

One change we did make was adding the support for <p> HTML tags for the error message. As such, you may need to update your translation string to include the <p> tag.

So you might have had:

'Submission saved.' => 'Submission saved override.'

Which would be:

'<p>Submission saved.</p>' => '<p>Submission saved override.</p>'

Sorry about that, I didn't realise this would be a breaking change. See https://github.com/verbb/formie/issues/1766

melissadoyon commented 3 months ago

Thanks for the clarification. I tested with the <p> tag and it works.