verbb / formie

The most user-friendly forms plugin for Craft CMS.
Other
93 stars 69 forks source link

Add more German translations, clean up #1838

Closed MoritzLost closed 2 months ago

MoritzLost commented 2 months ago

There are still some translations at the end of the de/formie.php file that aren't present in en/formie.php, but are used in the plugin. Maybe those could be added to en/formie.php as well and sorted properly in both files – I still don't get how those translations are ordered 🙃. Having both files in sync makes it much easier to contribute individual translations for new strings that are added to the core. I tried to clean up as much as possible.

@engram-design Follow up to #1836 and #1835 … yeah, a plan for keeping German translations up to date would be good. I can't really justify the time to do this every time 😇 Of course, we don't expect every plugin developer to have the same language support as the core. But as you said, having outdated/incorrect translations is sometimes worse than having no translations.

engram-design commented 2 months ago

Really appreciate your work on this, I would’ve hoped the original translation was workable.

Translations are a bit of a mess at the moment, and actively working on improving that, as well as automating the English ones so that stuff doesn’t get missed.

As for translations in general, imagine we didn’t have your excellent translations in place, would you rather see an automated, 90% complete German translation of things (an example https://gist.github.com/engram-design/00b9a12cb12d0d39d72809f1e7776d22) or would you rather see English instead?

Just tossing up our options here. CrowdIn is probably our best bet for accurate translations.

MoritzLost commented 2 months ago

@engram-design

As for translations in general, imagine we didn’t have your excellent translations in place, would you rather see an automated, 90% complete German translation of things (an example https://gist.github.com/engram-design/00b9a12cb12d0d39d72809f1e7776d22) or would you rather see English instead?

Not sure I can speak for all Germans here ^^

Personally, I don't care about translations, my account is always set to English. German is awkward for interfaces – too many long words and compound words, and technical terms that have no good translation.

Many of my clients will be fine using an English interface, but definitely not all.

90% German translations would be preferable over no German translations. However, accuracy of the translations is more important than completeness. A German interface with a couple of English strings in it is fine. But if the translations are inaccurate, misspelled or incorrect, that's a bigger problem. So having good translations is more important than having translations for everything, and bad translations are worse than no translations.

As an aside, I’ve been experimenting with Deepl to automate translations.

Those translations look pretty good!

DeepL is definitely the best option. Better than Google translate in my opinion. I also tried cleaning up the translations with ChatGPT 4, but it just told me to do it myself 🤷

Fully automatic will never work well:

Automatic translations with oversight by a human speaker is probably the way to go.

Just tossing up our options here. CrowdIn is probably our best bet for accurate translations.

I've contributed a couple of times in the Craft CMS CrowdIn. Kind of hard to navigate, but workable ^^

MoritzLost commented 2 months ago

@engram-design Can we get another release with this PR soon? Really want to finish the Formie integration in my current project :)

engram-design commented 2 months ago

Thanks for the feedback, certainly appreciate that!

I’ve added a little module here https://github.com/verbb/plugin-translator which at the very least automates and orders English translations, so you can expect a proper order to strings. Jury is still out on using Deepl’s translations though.

Should have a release over the weekend. I’ll ping you with one final update shortly.

MoritzLost commented 2 months ago

@engram-design That plugin translator looks like a really good starting point!

engram-design commented 2 months ago

I've just finalised the English translations, which are now automated for future use. They're alphabetically ordered to make it easier to deal with (apart from the special email messages).

As such, I've incorporated this into the German translations which follow the same order. The process of this was to start with the English file and pull in any matching values that you and others had made. This means that if any text has been missed, it'll still be in the German translation file it'll just be in English.

Hope that helps, and thanks for the continued support with this!

MoritzLost commented 2 months ago

@engram-design This looks great, thanks! Much easier to submit new translations this way. I see there are still a bunch of translations missing in German, if I have the time I'll submit some more translations as I come across them.