verbb / hyper

A Craft CMS plugin for managing links, focusing on user experience.
Other
21 stars 9 forks source link

Field instructions have poor contrast #159

Closed MoritzLost closed 1 month ago

MoritzLost commented 1 month ago

Describe the bug

The instructions for subfields in a link have poor contrast to the background and fail WCAG 2.2 Level AA:

Screenshot 2024-05-22 at 16 50 43

Screenshot 2024-05-22 at 16 50 54

Craft uses the --gray-550 variable for instructions, which is hsl(210, 13%, 40%), this one has better contrast, maybe switch to this color?

The same applies to the select field for the link type, the text has poor contrast to the background of the dropdown.

Steps to reproduce

  1. Add instructions to any field or attribute in a link field layout editor.

Craft CMS version

5.1.4

Plugin version

2.0.0

Multi-site?

No response

Additional context

No response

engram-design commented 1 month ago

I don't exactly love the lack of contrast now between the field label and the instructions. Visually, they look like they now carry the same hierarchal weight. But in the name of accessibility, we can make this change.

For comparison, see the below:

image

Fixed for the next release. To get this early, run:

MoritzLost commented 1 month ago

@engram-design Thanks, that looks much better! I think the bolding distinguishes the label well enough 👍

engram-design commented 1 month ago

Fixed in 2.0.1