verbb / navigation

A Craft CMS plugin to create navigation menus for your site.
Other
90 stars 23 forks source link

[Craft 3.5.x bug] Multi-site nav with 'Propagate nodes' disabled returns default site entries #173

Closed sjcallender closed 4 years ago

sjcallender commented 4 years ago

Description

With the "Propagate nodes" field disabled, we're expecting that we'd control each site's nav separately. This part works.

But we have two other problems:

  1. When we add a non-default site entry to a non-default site nav, the related entry in the node is still from the default site.
  2. When we add two entries to a non-default site nav, both entries return the same url.

Steps to reproduce

Per issue:

  1. Add non-default site entry as a node on a non-default site navigation menu. Watch screen recording: https://ssdd.d.pr/GX2P0A
  2. Add another non-default site entry as a node on the same nav and check the url result. Watch screen recording: https://ssdd.d.pr/pwwrc7

Additional info

sjcallender commented 4 years ago

We have another site on Craft 3.4.20 and Navigation 1.3.21 and this issue does not exist.

sjcallender commented 4 years ago

Hey @engram-design, this is a showstopper for us. Mind taking a look sooner than later?

engram-design commented 4 years ago

Looks like this is a 3.5 issue. Looking into it.

engram-design commented 4 years ago

Should be fixed in 1.3.23

sjcallender commented 4 years ago

@engram-design Thanks man. It looks like that fixed it. 🍻