verbb / navigation

A Craft CMS plugin to create navigation menus for your site.
Other
90 stars 23 forks source link

Requirements feed-me #215

Closed hhhc closed 4 years ago

hhhc commented 4 years ago

Hi,

just wanted to update to the latest version and I always got an error. Exception 'Error' with message 'Class 'craft\feedme\services\Elements' not found'

I found out that I had to manually do

composer require craftcms/feed-me

but I guess you could require that automatically.

engram-design commented 4 years ago

There are checks in place to ensure that Feed Me related code is only run if Feed Me is installed and enabled. Feed Me isn't a requirement for the Navigation plugin. My tests show on a fresh install (without Feed Me installed) I don't receive this error.

hhhc commented 4 years ago

That is weird because I did not have that installed and I could not upgrade without it. Well, feedme does not hurt and so I keep that installed.

engram-design commented 4 years ago

Hmmm, I'll keep an eye on this, as I'd rather not have this issue, yet no other reports of it just yet.

engram-design commented 4 years ago

Should be properly fixed in 1.4.5