verbb / navigation

A Craft CMS plugin to create navigation menus for your site.
Other
90 stars 23 forks source link

Non-admins can't move navigation items #301

Closed MoritzLost closed 2 years ago

MoritzLost commented 2 years ago

Description

We're seeing a bug in the current version of the plugin for Craft 4. Every user without admin privileges can't move navigation nodes. For admins, the little arrow icon shows up normally and can be used to drag and drop nodes to a new position:

navigation-admin

But for editors, the move handles are missing:

navigation-editor

Those editors have the permission to edit the navigation in question (navigation-manageNav:[uid]), but not to create new navigations or edit navigation settings or delete navigations.

Steps to reproduce

  1. Create a navigation.
  2. Log in as a non-admin user with permission to edit the navigation (but without permissions to create new navigations, edit navigation settings or delete navigations).
  3. Go to edit the navigation and try to move a node to a new permission.

Additional info

Additional context

engram-design commented 2 years ago

Should be fixed for the next release. To get the fix early, change your verbb/navigation requirement in composer.json to:

"require": {
  "verbb/navigation": "dev-craft-4 as 2.0.1",
  "...": "..."
}

Then run composer update.

MoritzLost commented 2 years ago

@engram-design That was fast, thanks! I've tested the dev branch and it solves the issue indeed. Looking forward to the next release!

engram-design commented 2 years ago

Fixed in 2.0.2