search

verbb / navigation

A Craft CMS plugin to create navigation menus for your site.
Other
90 stars 23 forks source link

A&M migration throws a "Site Settings cannot be blank" error #303

Closed aaronbushnell closed 2 years ago

aaronbushnell commented 2 years ago

Description I'm not positive this is the case, but it looks like commit dba86a1 made the siteSettings attribute of the Nav model required.

Because it's not set on the A&M (or Navee) migration process it throws an error that this value is not set.

Steps to reproduce

  1. Seed a database that has A&M Navigation data
  2. Initiate an A&M Navigation migration process

Additional info

aaronbushnell commented 2 years ago

And, sorry, I suppose this is true of version 1.4.26 also for folks stuck on Craft 3!

engram-design commented 2 years ago

Good point, I'd actually considered taking out these migration, because they're really only applicable to Craft 2/3, and we don't support going from Craft 2 to Craft 4 (same as Craft itself doesn't support that).

engram-design commented 2 years ago

This should be fixed in Navigation 1, and these migrations have been removed in Navigation 2 (for Craft 4), where they're no longer applicable. You'll need to perform the migrations from these Craft 2 plugins on Craft 3, before migrating to Craft 4 and beyond.

It's a bit annoying, but mimics how the rest of the Craft ecosystem works with staggered upgrades.