verbb / navigation

A Craft CMS plugin to create navigation menus for your site.
Other
90 stars 23 forks source link

On German installations after site switch accordions don't work #342

Closed gglnx closed 1 year ago

gglnx commented 1 year ago

Describe the bug

After switching the site context, the accordions to add links to the navigation thrown an JavaScript exception:

SCR-20230208-jk0

Looks for me like an encoding issue because of German umlauts. After clean reload:

SCR-20230208-jku

After AJAX site switch:

SCR-20230208-jkz

Steps to reproduce

  1. Switch to German for mighty Umlauts
  2. Open navigation with at least two enabled sites
  3. Edit navigation nodes
  4. Switch site
  5. Try to open an accordion with an Umlaut in the title

Craft CMS version

4.3.6.1

Plugin version

2.0.16

Multi-site?

Yes

Additional context

German as interface language selected

engram-design commented 1 year ago

Fixed for the next release. To get the fix early, change your verbb/navigation requirement in composer.json to:

"require": {
  "verbb/navigation": "dev-craft-4 as 2.0.16",
  "...": "..."
}

Then run composer update.

engram-design commented 1 year ago

2.0.17