search

verbb / patrol

Easy Maintenance Mode and Smart HTTPS Routing for Craft CMS
MIT License
29 stars 8 forks source link

getRequestingIp() getting local ip address from $_SERVER #12

Closed samhibberd closed 5 years ago

samhibberd commented 6 years ago

Hi Selvin,

We have noticed a couple of sites on one of our hosts running into an issue where the getRequestingIp() function is returning a local address '127.0.0.1' rather than the client IP, it looks to be related to inconsistencies between the values stored in $_SERVER, maybe if a proxy is used:

https://github.com/selvinortiz/craft-plugin-patrol/blob/6728e1996c7df4cdf49482841e01cce1f7728149/src/services/PatrolService.php#L286

It looks as though our server (with kyup on cloudways) reports the correct ip in both $_SERVER['HTTP_X_FORWARDED_FOR'] and $_SERVER['HTTP_X_REAL_IP'].

There looks to be a load of different approaches out there, not sure which is the most reliable.

Thanks,

Sam

selvinortiz commented 6 years ago

Sam, Thank you for bringing this up.

I initially addressed CloudFlare hosting environments but Patrol is being used in many more environments now and we definitely need to figure out how to support proxies, Heroku/Fortrabbit style environments, etc.

I've had limited time to work on my plugins lately and I know it's holding a few people back in some cases.

selvinortiz commented 5 years ago

@samhibberd The latest release should address this issue. If you learn otherwise in your testing, please let me know.