search

verbb / patrol

Easy Maintenance Mode and Smart HTTPS Routing for Craft CMS
MIT License
29 stars 8 forks source link

getRequestingIp() return value bug #23

Closed samhibberd closed 2 years ago

samhibberd commented 4 years ago

Hey @selvinortiz

Ran into an issue with the getRequestingIp() method returning a bool value rather than the ip address, just needs the isset() removed from the value returned, see:

https://github.com/selvinortiz/craft-plugin-patrol/blob/f6037183324d6046e4121a9005702b39ff89e6b8/src/services/PatrolService.php#L305

https://github.com/selvinortiz/craft-plugin-patrol/blob/f6037183324d6046e4121a9005702b39ff89e6b8/src/services/PatrolService.php#L309

engram-design commented 2 years ago

Fixed in 4.0.1