search

verbb / postie

A Craft Commerce shipping calculator plugin.
Other
12 stars 18 forks source link

Shipping Number is required by Ups #111

Closed thomasdefilippis closed 1 year ago

thomasdefilippis commented 1 year ago

So, ups stopped working when I updated to 3.1.1 with oauth. Figured out the problem was that the shipping account number was removed. Reading it back in solved my issue. Any feedback on why this got removed?

engram-design commented 1 year ago

The accountNumber is not required for fetching rates from UPS. You only need clientId and clientSecret from my testing. It is however required if you want to use negotiated rates. You can confirm this via their docs as being optional.

This is already added to the payload via https://github.com/verbb/postie/blob/2d5abc332971e9d979792c07094d1b8859bb984c/src/providers/UPS.php#L411

engram-design commented 1 year ago

Actually, my mistake that's using the new syntax for Postie v4 that I'm actively working on in parallel.

See https://github.com/verbb/postie/commit/6d3676b06406e039b0c3e6aab6b84acd67030111

thomasdefilippis commented 1 year ago

Cool, I see. good to know. I will look out for the release.

Any idea when v4 will be out?

thomasdefilippis commented 1 year ago

Can you possibly merge my request into 3.1.1 so that ups will show up for me on that version?

engram-design commented 1 year ago

@thomasdefilippis Postie v4 will be in the next month or two.

If you run composer require verbb/postie:"dev-craft-4 as 3.1.1" you can get this fix early, which should get things working. Let me know if it still isn't?