verbb / postie

A Craft Commerce shipping calculator plugin.
Other
12 stars 18 forks source link

`modifyShippingMethods` event appears in docs but isn't actually included in the latest release. #66

Closed michaelrog closed 3 years ago

michaelrog commented 3 years ago

The docs describe a modifyShippingMethods event.

Alas, I am unable to find this event implemented anywhere in the code.

...which is super sad, because it's exactly the event I need this morning. 😅

Steps to reproduce

  1. Attempt to attach an event listener to the modifyShippingMethods event; scratch head when it doesn't work.
  2. Ctrl-F in the code, attempting to find where the modifyShippingMethods is implemented; scratch head when it cannot be found.

Additional info

michaelrog commented 3 years ago

Ah, I do see where this event was implemented in 41f3273... so I guess it just hasn't made it to release yet.

Force-installing the latest files gets me what I need for now...

"require": {
    "verbb/postie": "dev-craft-3 as 2.4.7",
},

...but I feel kinda dirty pushing this to prod. Hope it gets tagged soon. 🙏🏼

engram-design commented 3 years ago

Yep, I was awaiting some feedback for support requests (that've taken a while to get back to me). I'll be sure to tag a release soon!

engram-design commented 3 years ago

Added in 2.4.8