search

verbb / smith

A Craft CMS plugin to add copy, paste and clone functionality to Matrix blocks.
MIT License
25 stars 9 forks source link

Breaks When Two Matrix Components are on an Entry #34

Open DynamiteGoesBoom opened 9 months ago

DynamiteGoesBoom commented 9 months ago

Describe the bug

We have a Hero Builder and a Content Builder on our Entries like so:

⚙-Team-Section-Gets-Some-Love-Get-Fido

But now when we click on either type in the Hero Builder, nothin happens

Also the Paste doesn't really work when copying from the same Content Builder component on another page.

Steps to reproduce

  1. add 2 matrix fields with multiple blocks
  2. copy block to new page
  3. try adding a new block manually to the non-copied block

Craft CMS version

Craft Pro 4.5.11.1

Plugin version

2.0.0

Multi-site?

No response

Additional context

No response

engram-design commented 9 months ago

What's that UI above the Matrix block buttons? Another plugin, custom field, or something? It's not something I've seen before.

EDIT: Ah, this seems like it's the Batch Actions plugin. Is this a Smith issue?

DynamiteGoesBoom commented 9 months ago

That would be Batch Actions. I use that along with Matrix Mate to add some nice AX touches. Smith looks like it integrates pretty well with it.

DynamiteGoesBoom commented 9 months ago

Yep, you got it. But yes Smith is breaking the hero builder field. Once I turned it off the hero Builder started working again.

DynamiteGoesBoom commented 9 months ago

It's not a deal breaker as word on the street is that Smith-like functionality is coming to Craft 5. So if it's too big of a lift to get everything about Smith working, then I can wait too. I just like the idea of being able to easily clone matrix data. But not sure if the reward is worth the effort.

Thanks Josh!

engram-design commented 9 months ago

Hmm, so copy-paste across entries seems to be working okay for me, but then I probably need to test in combination with Matrix Mate and Batch Actions, in case there's some conflict there.

But yes, it's probably going to be largely no longer required in Craft 5, but waiting for the dev preview to settle on that one before making a final decision. Also seems like Batch Actions might do a better job anyway!

DynamiteGoesBoom commented 9 months ago

Yeah but Batch Actions doesn't copy/paste. i did find it interesting that BA and Smith played nicely together though. Although the functionality didn't work. But BA placed the Smith commands in as part of BA. If that makes sense. I didn't test Smith out by itself as BA does a bit more of what our clients like.

That sounds good about C5 and hopefully that all will be decided soon. Thanks for looking into this as i know you're quite the busy guy these days 🎉

engram-design commented 9 months ago

Oh, I thought it did, based on the screenshot above, but I see what Batch Actions is doing - neat!

DynamiteGoesBoom commented 9 months ago

Haha, no worries. It is a pretty nifty little plugin. If you had time to sort out the issue I'd love to see it. No biggie either way. Thanks again for all that you do!