search

verbb / snipcart

A Craft CMS plugin to integrate with Snipcart.
Other
21 stars 9 forks source link

Whitespace control outputs additionalProps without trailing space #44

Closed bleepsandblops closed 9 months ago

bleepsandblops commented 2 years ago

Adding the option additionalProps outputs them without trailing space: Screenshot 2022-03-24 at 11 06 48

I believe the issue is here: https://github.com/FosterCommerce/snipcart-craft-plugin/blob/de517a75458a61b83970eba0d48bc3c3ca102454/src/templates/fields/front-end/buy-now.twig#L40

Need to replace with {% endfor %}

sjcallender commented 10 months ago

https://github.com/FosterCommerce/snipcart-craft-plugin/issues/55

engram-design commented 10 months ago

We'll likely completely replace this manual output with HTML helpers that'll fix this.

engram-design commented 9 months ago

Fixed in 2.1.0