search

verbb / social-share

A Craft CMS plugin to generate social media buttons, share dialogs and share counts.
MIT License
1 stars 0 forks source link

`renderShareButton` does not output the `data-url` attribute on the generated link element #6

Open kevincote opened 1 month ago

kevincote commented 1 month ago

Describe the bug

When using the helper craft.socialShare.renderShareButton('facebook') with the default configuration (so useModalForShare is true, there is no data-url=[...] attribute attached to the <a> tag, therefore the share functionality does not work.

Steps to reproduce

  1. Put {{ craft.socialShare.renderShareButton('facebook') }} anywhere on the page.
  2. The generated tag does not include the data-url attribute.

Craft CMS version

5.2.0

Plugin version

2.0.1

Multi-site?

No

Additional context

No response

engram-design commented 1 month ago

Fixed for the next release. To get this early, run composer require verbb/social-share:"dev-craft-5 as 2.0.1".