verbb / vizy

A flexible visual editor for Craft CMS
Other
44 stars 8 forks source link

Editing vizy text in matrix field wil not save. #216

Closed FransvdWijst closed 1 year ago

FransvdWijst commented 1 year ago

Describe the bug

When using the vizy texteditor in matrix fields, the modifications will not be saved. It won't update the preview page (update the draft) when editing content in the vizy teksteditor.

We noticed the problem in Vizy version 2.1.1 and updated vizy 2.1.3. So the problem was already active in V2.1.1.

We also have Craft 3 websites using the same setup, here the problem doesn't exist.

Steps to reproduce

  1. Create a Matrix blocktype and a field with Fieldtype: Vizy
  2. Create a new vizy field, and add a vizy block containing the above matrix field. image
  3. Create a new entry (where this matrix block is used) ad some dummy tekst and save the entry (the content will be saved correctly)
  4. Open the saved entry, and try to edit the vizy content in the matrix field. You will notice the field doesn't update the draft, the preview is not updated and the modifications won't be saved.

This is how my test page looks like: image

Craft CMS version

Craft Pro 4.4.7.1

Plugin version

2.1.3

Multi-site?

Yes

Additional context

No response

engram-design commented 1 year ago

Just so I'm clear, refer to the screen recording for my steps to reproduce. Is that correct?

https://user-images.githubusercontent.com/1221575/234422352-77167138-940f-4b69-bb96-330ca0bbb668.mp4

FransvdWijst commented 1 year ago

I notice it is more specific then that. There is a step in between which i missed.

The basic setup is: Vizy field -> Vizy Block container matrix field -> This matrix field containens another vizy field.

I updated the Steps to reproduce, and added screenshots to clarify. Later today I will be able to make a screen recording so you can see it happening.

FransvdWijst commented 1 year ago

As promised, a screen recording:

https://user-images.githubusercontent.com/105865888/234643488-1516c344-7a88-4099-9d5b-3883236e4967.mp4

engram-design commented 1 year ago

Ah, that makes sense. Fixed for the next release. To get this early, run composer require verbb/vizy:"dev-craft-4 as 2.1.3"

FransvdWijst commented 1 year ago

Today we ware able to test the fix via version "dev-craft-4".

This did fix tix the isseu when editing the tekst within a matrix field. With this fix, another error appears. If you want to add a new matrix element, the input field is not visible at all. When you save the page, and re-open it for editing the input field will be visible,and then you will be able to add content.

At the moment I am not able to make screen recordings, but i am able to post screenshots: image image

Then save the page, and re-open. The field is shown and fully functional. image

If a screencapture helps to clearify, just let me know. I will make sure i have one.

engram-design commented 1 year ago

Are you able to run composer require verbb/vizy:"dev-craft-4 as 2.1.3" again to see if (another) fix fixes that for you?

engram-design commented 1 year ago

Should be fixed in 2.1.4