search

verbb / vizy

A flexible visual editor for Craft CMS
Other
43 stars 8 forks source link

Iframe nodes not rendering #265

Closed d-karstens closed 8 months ago

d-karstens commented 8 months ago

Describe the bug

Hi, we've encountered an issue where iframes are not rendering correctly using renderHtml(), despite saving correctly

Here's a dump of the data in our template - looks like the url is there, but it should be in attrs['src']

Screenshot 2023-10-16 at 3 21 38 pm

Seems to be related to this logic https://github.com/verbb/vizy/blob/craft-4/src/nodes/Iframe.php#L22

Steps to reproduce

  1. Save a field with an iframe
  2. Iframe is not rendered using field.renderHtml()

Craft CMS version

4.5.6.1

Plugin version

2.1.11

Multi-site?

No

Additional context

No response

engram-design commented 8 months ago

Fixed for the next release. To get this early, run composer require verbb/vizy:"dev-craft-4 as 2.1.11"

d-karstens commented 8 months ago

Thank you!

engram-design commented 8 months ago

Fixed in 2.1.12