verbb / vizy

A flexible visual editor for Craft CMS
Other
44 stars 8 forks source link

"Showing your unsaved changes." on opening entry #317

Open f-elix opened 6 days ago

f-elix commented 6 days ago

Describe the bug

Opening an entry with a Vizy field triggers a "Showing your unsaved changes." notification. I know this has been reported in the past (https://github.com/verbb/vizy/issues/287) but I'm still encountering this.

Steps to reproduce

  1. Add a Vizy field to an entry
  2. Visit the entry page

Craft CMS version

4.12.7

Plugin version

2.1.23

Multi-site?

Yes

Additional context

No response

engram-design commented 5 days ago

Can you detail if you have any combination of different fields at play (Matrix, Neo, Vizy) either outside or inside the Vizy field? Nested fields can cause this. And if you can let me know what sort of content (just rich text, Vizy blocks, etc)?

f-elix commented 5 days ago

Yeah sorry!

The field has both rich text and Vizy blocks. Some blocks do contain matrix and Redactor fields, but no Neo. I didn't think it was relevant to mention though because the issue appears even if the field is completely empty.

There are also some Neo fields in the entry, but outside the Vizy field. There are no Vizy fields inside the Neo fields though.

f-elix commented 5 days ago

Also, I don't have this issue in Craft 5 and v3.0.4

engram-design commented 4 days ago

Cool, good to know you're getting it if the field is empty, but still just wanted to check if it was an empty field within Matrix, etc for example. I guess if you're able to send through a screenshot or video of the issue reproduced with as minimal field setup and content, I can try to replicate that.

We've been working on improving this for Craft 5+, with changes to both Vizy and Craft.

f-elix commented 4 days ago

I'm trying to make a minimal reproduction, trying several combinations of fields, but the issue occurs intermittently (worse kind of bug). I'll keep trying and hopefully come back to you with more details. So far, all I can see is that it seems to have something to do with Neo and/or Redactor fields being present in the same entry type.