verbb / workflow

A Craft CMS plugin to create a workflow for publishing entries.
Other
140 stars 27 forks source link

"Editor Submission Notes Required" doesn't function #192

Closed darylknight closed 8 months ago

darylknight commented 11 months ago

Describe the bug

Possibly a regression of #59

Our Editor group permissions look like this:

image

This means that in order to edit or submit anything, their first step is to Create a draft. Once they've done that, they can make changes, then submit for review. I've enabled the setting that requires submission notes here:

image

However, when they make changes, it is not actually a required field, and they can submit their draft for approval without notes:

image

Steps to reproduce

  1. Enable the lightswitch for "Editor Submission Notes Required"
  2. Submit a draft for approval without adding any notes

Craft CMS version

4.4.16.1

Plugin version

2.0.5

Multi-site?

No

Additional context

No response

engram-design commented 11 months ago

Fixed for the next release. To get this early, run composer require verbb/workflow:"dev-craft-4 as 2.0.5".

engram-design commented 8 months ago

Fixed in 2.0.6