verbb / workflow

A Craft CMS plugin to create a workflow for publishing entries.
Other
140 stars 27 forks source link

XSS: Missing HTML escaping in Submission::getEditorUrl #92

Closed d--j closed 4 years ago

d--j commented 4 years ago

Description

Submission::getEditorUrl and Submission::getPublisherUrl are missing HTML escaping. This can easily be exploited by a malicious editor.

https://github.com/verbb/workflow/blob/a3cbb2b65ee88b8bef6a15b879292c325d119d01/src/elements/Submission.php#L168-L181

Steps to reproduce

  1. Editor changes her user profile, adds malicious stuff like the following:

    My_Account_-_HUAWEI_Rebels
  2. The next time a publisher accesses the submission list:

    Workflow_Overview_-_HUAWEI_Rebels

Additional info

engram-design commented 4 years ago

Fixed in 1.3.0